Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost dbname when only passing collection id to describeCollection #31177

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Mar 11, 2024

issue: #30931
pr: #31167

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.23%. Comparing base (9d712f4) to head (cfb5a65).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31177      +/-   ##
==========================================
- Coverage   82.24%   82.23%   -0.02%     
==========================================
  Files         844      844              
  Lines      122225   122240      +15     
==========================================
- Hits       100521   100519       -2     
- Misses      18472    18488      +16     
- Partials     3232     3233       +1     
Files Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 87.88% <100.00%> (+0.12%) ⬆️
internal/rootcoord/meta_table.go 82.46% <100.00%> (ø)
internal/rootcoord/root_coord.go 90.82% <100.00%> (+0.01%) ⬆️
internal/rootcoord/describe_collection_task.go 82.35% <40.00%> (-17.65%) ⬇️

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 11, 2024
@jaime0815
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Mar 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7105e0b into milvus-io:2.3 Mar 11, 2024
14 checks passed
@chyezh chyezh deleted the fixup_dbid_dbname_2_3 branch March 12, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants