Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: When describing an index, fetch the index info in batches #31239

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #29313
master pr: #31238

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 13, 2024
Copy link
Contributor

mergify bot commented Mar 13, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (7105e0b) to head (fa77828).
Report is 8 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31239      +/-   ##
==========================================
- Coverage   82.24%   82.21%   -0.03%     
==========================================
  Files         844      844              
  Lines      122234   122258      +24     
==========================================
- Hits       100526   100518       -8     
- Misses      18480    18496      +16     
- Partials     3228     3244      +16     
Files Coverage Δ
internal/datacoord/index_meta.go 98.13% <87.50%> (-0.42%) ⬇️
internal/datacoord/index_service.go 94.44% <88.88%> (-0.93%) ⬇️

... and 17 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 14, 2024
@czs007
Copy link
Collaborator

czs007 commented Mar 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ef530a2 into milvus-io:2.3 Mar 15, 2024
14 checks passed
@xiaocai2333 xiaocai2333 deleted the get_segments_indexes_pick branch May 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants