Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug for get segment index state #31429

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #31361
master pr: #31427
2.4 pr: #31428

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Mar 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 20, 2024
@czs007
Copy link
Collaborator

czs007 commented Mar 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (86e347a) to head (45149bb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #31429   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files         844      844           
  Lines      122292   122291    -1     
=======================================
+ Hits       100550   100552    +2     
+ Misses      18507    18504    -3     
  Partials     3235     3235           
Files Coverage Δ
internal/datacoord/index_meta.go 98.13% <100.00%> (-0.01%) ⬇️

... and 16 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 20, 2024
@sre-ci-robot sre-ci-robot merged commit 52a7eb9 into milvus-io:2.3 Mar 20, 2024
14 checks passed
@xiaocai2333 xiaocai2333 deleted the fix_bug_get_index_state-2.3 branch May 10, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants