Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: double buffer was invalid when put entry which size larger than max size #31549

Merged
merged 2 commits into from
Mar 23, 2024
Merged

fix: double buffer was invalid when put entry which size larger than max size #31549

merged 2 commits into from
Mar 23, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Mar 22, 2024

relate: #31548

@aoiasd
fix double buffer was invalid when put entry which size larger than m…
65243e7 
…ax size

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 22, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Mar 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 22, 2024

@aoiasd Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Mar 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 22, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 22, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 22, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Mar 22, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 22, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.26%. Comparing base (ab059bb) to head (05f461b).
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31549      +/-   ##
==========================================
+ Coverage   82.25%   82.26%   +0.01%     
==========================================
  Files         844      844              
  Lines      122691   122709      +18     
==========================================
+ Hits       100914   100942      +28     
+ Misses      18538    18525      -13     
- Partials     3239     3242       +3
Files Coverage Δ
...uerynodev2/delegator/deletebuffer/delete_buffer.go 100.00% <100.00%> (+24.56%) ⬆️

... and 20 files with indirect coverage changes

@congqixia
Copy link
Contributor

/run-cpu-e2e

@aoiasd
add test
05f461b 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Mar 23, 2024
@mergify mergify bot added the ci-passed label Mar 23, 2024
@congqixia
Copy link
Contributor

/kind branch-feature

congqixia
congqixia approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7c234f2 into milvus-io:2.3 Mar 23, 2024
14 checks passed
aoiasd added a commit to aoiasd/milvus that referenced this pull request Jul 31, 2024
@aoiasd
fix: double buffer was invalid when put entry which size larger than …
1e49e96 
…max size (milvus-io#31549)

relate: milvus-io#31548

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
aoiasd added a commit to aoiasd/milvus that referenced this pull request Jul 31, 2024
@aoiasd
fix: double buffer was invalid when put entry which size larger than …
5b1bc8f 
…max size (milvus-io#31549)

relate: milvus-io#31548

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
aoiasd added a commit to aoiasd/milvus that referenced this pull request Aug 2, 2024
@aoiasd
fix: double buffer was invalid when put entry which size larger than …
3ebdca8 
…max size (milvus-io#31549)

relate: milvus-io#31548

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
aoiasd added a commit to aoiasd/milvus that referenced this pull request Aug 21, 2024
@aoiasd
fix: double buffer was invalid when put entry which size larger than …
5797101 
…max size (milvus-io#31549)

relate: milvus-io#31548

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
aoiasd added a commit to aoiasd/milvus that referenced this pull request Aug 22, 2024
@aoiasd
fix: double buffer was invalid when put entry which size larger than …
e966909 
…max size (milvus-io#31549)

relate: milvus-io#31548

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aoiasd @congqixia @sre-ci-robot