Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minio ssl compatible issue #31619

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: minio ssl compatible issue #31619

merged 1 commit into from
Mar 27, 2024

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented Mar 26, 2024

issue: #30709
pr: #31607

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 26, 2024
Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@yhmo yhmo changed the title Fix minio ssl compatible issue fix: minio ssl compatible issue Mar 26, 2024
Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yhmo <yihua.mo@zilliz.com>
Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented Mar 26, 2024

/run-cpu-e2e

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 82.38%. Comparing base (5031528) to head (9100d0e).
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31619      +/-   ##
==========================================
+ Coverage   82.35%   82.38%   +0.03%     
==========================================
  Files         848      838      -10     
  Lines      124489   124409      -80     
==========================================
- Hits       102520   102498      -22     
+ Misses      18684    18635      -49     
+ Partials     3285     3276       -9     
Files Coverage Δ
internal/proxy/accesslog/minio_handler.go 76.19% <ø> (ø)
internal/storage/minio_object_storage.go 75.15% <ø> (ø)
pkg/util/paramtable/service_param.go 98.54% <100.00%> (-0.01%) ⬇️
internal/core/src/storage/ChunkManagers.cpp 0.00% <0.00%> (ø)
internal/core/src/storage/MinioChunkManager.cpp 0.00% <0.00%> (ø)

... and 161 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Mar 26, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

4 similar comments
Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 26, 2024

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yanliang567 yanliang567 added the manual-pass manually set pass before ci-passed labeled label Mar 27, 2024
@yanliang567 yanliang567 added this to the 2.3.13 milestone Mar 27, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 91cdada into milvus-io:2.3 Mar 27, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants