Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip changing meta if nodeID not match with channel #31665

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Mar 27, 2024

See also: #31648
pr: #31666

See also: milvus-io#31648

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Mar 27, 2024
Copy link
Contributor

mergify bot commented Mar 27, 2024

@XuanYang-cn Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.36%. Comparing base (91cdada) to head (feedf62).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #31665      +/-   ##
==========================================
- Coverage   82.39%   82.36%   -0.03%     
==========================================
  Files         838      848      +10     
  Lines      124409   124513     +104     
==========================================
+ Hits       102507   102557      +50     
- Misses      18627    18675      +48     
- Partials     3275     3281       +6     
Files Coverage Δ
internal/datanode/services.go 82.85% <100.00%> (-0.05%) ⬇️
internal/datacoord/compaction.go 94.27% <89.18%> (-0.58%) ⬇️

... and 168 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 69931a6 into milvus-io:2.3 Mar 28, 2024
14 checks passed
sre-ci-robot pushed a commit that referenced this pull request Apr 10, 2024
…#31672)

See also: #31648
pr: #31665, #31694

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants