Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.3] Use server ctx instead of loopCtx for datacoord LivenessCheck (#31691) #31747

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #31691
See also #31689

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Mar 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 29, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.36%. Comparing base (7394c51) to head (768ba6c).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #31747   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         848      848           
  Lines      124566   124566           
=======================================
+ Hits       102593   102602    +9     
+ Misses      18692    18686    -6     
+ Partials     3281     3278    -3     
Files Coverage Δ
internal/datacoord/server.go 70.22% <0.00%> (ø)

... and 6 files with indirect coverage changes

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 1, 2024
@yanliang567 yanliang567 added this to the 2.3.13 milestone Apr 1, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit ba36f66 into milvus-io:2.3 Apr 3, 2024
12 of 14 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants