Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: enforce milvus.yaml assertion in UT #32357

Merged
merged 1 commit into from
Apr 19, 2024
Merged

enhance: enforce milvus.yaml assertion in UT #32357

merged 1 commit into from
Apr 19, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Apr 17, 2024

See #32168

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Apr 17, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
enhance: enforce milvus.yaml assertion in UT
0c7d1b9 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu force-pushed the enhance/enforce_file_assertion branch from 1f89fb8 to 0c7d1b9 Compare April 19, 2024 02:01
@mergify mergify bot added the ci-passed label Apr 19, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (66fae53) to head (0c7d1b9).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32357      +/-   ##
==========================================
- Coverage   81.76%   81.41%   -0.36%     
==========================================
  Files         999      999              
  Lines      124008   124008              
==========================================
- Hits       101400   100958     -442     
- Misses      18739    19171     +432     
- Partials     3869     3879      +10

see 44 files with indirect coverage changes

congqixia
congqixia approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 744a54a into milvus-io:master Apr 19, 2024
15 checks passed
@tedxu tedxu deleted the enhance/enforce_file_assertion branch April 23, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@yhmo yhmo Awaiting requested review from yhmo

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tedxu @sre-ci-robot @congqixia