Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "enhance: trigger compaction by size (#32326)" #32745

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Apr 30, 2024

This reverts commit fef7812.

This reverts commit fef7812.

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

@tedxu Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Apr 30, 2024

@tedxu

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@czs007
Copy link
Collaborator

czs007 commented Apr 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 85.41667% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 81.76%. Comparing base (51e0855) to head (723137c).
Report is 384 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #32745      +/-   ##
==========================================
+ Coverage   81.58%   81.76%   +0.17%     
==========================================
  Files         976      998      +22     
  Lines      120147   124375    +4228     
==========================================
+ Hits        98019   101689    +3670     
- Misses      18396    18809     +413     
- Partials     3732     3877     +145     
Files Coverage Δ
internal/datacoord/compaction_trigger.go 83.08% <85.41%> (ø)

... and 259 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 30, 2024
@sre-ci-robot sre-ci-robot merged commit 15b7874 into milvus-io:2.4 Apr 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants