Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove useless common types and refine error assert in negative cases #33023

Merged
merged 2 commits into from
May 14, 2024

Conversation

yanliang567
Copy link
Contributor

Related issue: #32653

  1. Remove some meaningless common types
  2. Refine error assertion in negative cases
  3. Remove some dup tests

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XXL Denotes a PR that changes 1000+ lines. area/test sig/testing labels May 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/test labels May 13, 2024
Copy link
Contributor

mergify bot commented May 13, 2024

@yanliang567 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
@mergify mergify bot added the ci-passed label May 14, 2024
@binbinlv
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit ba3b2a9 into milvus-io:master May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants