New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Major compaction #33620

Merged

czs007 merged 1 commit into milvus-io:master from wayblink:merge-major-100

Jun 10, 2024

Contributor

wayblink commented Jun 5, 2024 •

edited

Loading

sre-ci-robot added do-not-merge/work-in-progress area/compilation area/internal-api area/test sig/testing test/integration size/XXL labels

sre-ci-robot requested review from aoiasd and bigsheeper

June 5, 2024 02:43

mergify bot added the needs-dco label

Contributor

mergify bot commented Jun 5, 2024

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify bot added the do-not-merge/invalid-pr-format label

Contributor

mergify bot commented Jun 5, 2024

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

Title Format: The PR title must begin with one of these prefixes:

feat: for introducing a new feature.
fix: for bug fixes.
enhance: for improvements to existing functionality.
test: for add tests to existing functionality.
doc: for modifying documentation.
auto: for the pull request from bot.

Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

wayblink force-pushed the merge-major-100 branch from 14ee256 to ba84e9d Compare

June 5, 2024 03:12

Contributor

mergify bot commented Jun 5, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

wayblink force-pushed the merge-major-100 branch from ba84e9d to 442ff73 Compare

June 5, 2024 04:20

Contributor

mergify bot commented Jun 5, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

wayblink force-pushed the merge-major-100 branch from 442ff73 to a0ec946 Compare

June 5, 2024 06:18

Contributor

mergify bot commented Jun 5, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

wayblink force-pushed the merge-major-100 branch from a0ec946 to a4e7a2d Compare

June 5, 2024 08:39

Contributor

mergify bot commented Jun 5, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment

Contributor

mergify bot commented Jun 5, 2024

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

wayblink force-pushed the merge-major-100 branch 2 times, most recently from 7ec78cd to 5af95b4 Compare

June 5, 2024 11:29

Contributor

mergify bot commented Jun 5, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink force-pushed the merge-major-100 branch 3 times, most recently from b8e972b to d83a840 Compare

June 6, 2024 09:54

mergify bot added dco-passed and removed needs-dco labels

sre-ci-robot assigned czs007

sre-ci-robot added the lgtm label

Contributor

sre-ci-robot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot added the approved label

Contributor Author

wayblink commented Jun 7, 2024

rerun ut

wayblink force-pushed the merge-major-100 branch from 33319cc to aaaaabd Compare

June 7, 2024 06:18

Contributor

sre-ci-robot commented Jun 7, 2024

New changes are detected. LGTM label has been removed.

sre-ci-robot removed the lgtm label

wayblink force-pushed the merge-major-100 branch from aaaaabd to 6a643b3 Compare

June 7, 2024 08:12

Contributor

mergify bot commented Jun 7, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Collaborator

czs007 commented Jun 7, 2024

/run-cpu-e2e

Contributor

mergify bot commented Jun 7, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Collaborator

czs007 commented Jun 7, 2024

/run-cpu-e2e

Contributor

mergify bot commented Jun 7, 2024

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Contributor Author

wayblink commented Jun 7, 2024

/run-cpu-e2e


          Major compaction

1e36c69

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

wayblink force-pushed the merge-major-100 branch from 6a643b3 to 1e36c69 Compare

June 7, 2024 10:16

czs007 merged commit a1232fa into milvus-io:master

11 of 13 checks passed

czs007 added the PR | need cherry-pick label

wayblink added a commit to wayblink/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

776e389

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

wayblink mentioned this pull request

feat: [cherry-pick] Major compaction #34326

Merged

wayblink added a commit to wayblink/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

487f50d

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

wayblink added a commit to wayblink/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

e86f17d

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

wayblink added a commit to wayblink/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

54ba63e

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

wayblink added a commit to wayblink/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

db0078c

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

wayblink added a commit to wayblink/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

29c8f37

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

wayblink added a commit to wayblink/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

a340891

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

czs007 pushed a commit that referenced this pull request


          feat: [cherry-pick] Major compaction (#34326)

This PR cherry-picks the following commits:
fix: speed up segment lookup via channel name in datacoord (#33530)
needed by the next commit
  feat: Major compaction (#33620)

issue: #30633
pr: #33620

---------

Signed-off-by: yiwangdr <yiwangdr@gmail.com>
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: yiwangdr <80064917+yiwangdr@users.noreply.github.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request


          feat: Major compaction (milvus-io#33620)

412a927

milvus-io#30633

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: MrPresent-Han <chun.han@zilliz.com>

czs007 removed the PR | need cherry-pick label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/compilation area/internal-api area/test dco-passed kind/feature sig/testing size/XXL test/integration