Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compaction task l0 state transfer wrong #34597

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

XuanYang-cn
Copy link
Contributor

This bug caused failed L0 compaction tasks never end.

See also: #34460

This bug caused failed L0 compaction tasks never end.

See also: milvus-io#34460

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 11, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jul 11, 2024
This bug caused failed L0 compaction tasks never end.

See also: milvus-io#34460
pr: milvus-io#34597

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/approve
/lgtm

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm label Jul 11, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot removed the lgtm label Jul 11, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/lgtm

sre-ci-robot pushed a commit that referenced this pull request Jul 11, 2024
This bug caused failed L0 compaction tasks never end.

See also: #34460
pr: #34597

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added the ci-passed label Jul 11, 2024
@sre-ci-robot sre-ci-robot merged commit d7966f4 into milvus-io:master Jul 11, 2024
10 checks passed
@XuanYang-cn XuanYang-cn deleted the cp/fix-task-l0 branch July 12, 2024 00:57
chyezh pushed a commit to chyezh/milvus that referenced this pull request Jul 15, 2024
This bug caused failed L0 compaction tasks never end.

See also: milvus-io#34460

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants