Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick] Batch pick bug fix PRs #34657

Merged

Conversation

bigsheeper and others added 5 commits July 12, 2024 16:49
…us-io#34563)

When the main dispatcher has not yet consumed data, curTs is 0. During
this time, merging dispatchers should not be allowed; otherwise, the
data of the solo dispatcher will be skipped.

issue: milvus-io#34255

pr: milvus-io#34562

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
…ilvus-io#34071)

When import failed, mark the import segment as dropped instead of drop
it directly to prevent generating orphaned files.

issue: milvus-io#34068

pr: milvus-io#34070

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
issue: issue: milvus-io#34247

pr: milvus-io#34267

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 12, 2024
@bigsheeper bigsheeper added this to the 2.3.19 milestone Jul 12, 2024
@czs007 czs007 modified the milestones: 2.3.19, 2.4.5-hotfix Jul 12, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 12, 2024

/run-cpu-e2e

@czs007
Copy link
Contributor

czs007 commented Jul 13, 2024

@bigsheeper please fix the bug of building go test

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (7f47f0d) to head (4418623).
Report is 4 commits behind head on hotfix-2.4.5.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           hotfix-2.4.5   #34657   +/-   ##
=============================================
  Coverage         81.94%   81.95%           
=============================================
  Files              1015     1015           
  Lines            129462   129522   +60     
=============================================
+ Hits             106094   106152   +58     
+ Misses            19363    19362    -1     
- Partials           4005     4008    +3     
Files Coverage Δ
internal/core/src/segcore/InsertRecord.h 91.25% <100.00%> (+0.03%) ⬆️
internal/datanode/writebuffer/l0_write_buffer.go 91.60% <100.00%> (ø)
pkg/mq/msgdispatcher/dispatcher.go 94.59% <100.00%> (+0.03%) ⬆️
pkg/mq/msgdispatcher/manager.go 95.75% <100.00%> (ø)
pkg/util/funcutil/func.go 91.80% <100.00%> (+0.34%) ⬆️
internal/datacoord/import_scheduler.go 70.79% <66.66%> (+0.44%) ⬆️

... and 40 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 13, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jul 13, 2024
@sre-ci-robot sre-ci-robot merged commit 9e593f8 into milvus-io:hotfix-2.4.5 Jul 13, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants