comp_id.module doesn't work for nested modules

[corakingdon]

Example:

using Mimi

module foo
    using Mimi
    module bar
        using Mimi
        @defcomp c begin
        end
    end
    function get_model()
        m = Model()
        set_dimension!(m, :time, 1:10)
        add_comp!(m, bar.c)
        return m
    end
end

m = foo.get_model()
run(m)

Gives the error:

ERROR: LoadError: UndefVarError: bar not defined
Stacktrace:
 [1] get_module at C:\Users\Cora\.julia\packages\Mimi\R2d8T\src\core\defs.jl:2 [inlined]
 [2] Mimi.ComponentInstance{Mimi.ComponentInstanceVariables{NamedTuple{(),Tuple{}}},Mimi.ComponentInstanceParameters{NamedTuple{(),Tuple{}}}}(::Mimi.ComponentDef, ::Mimi.ComponentInstanceVariables{NamedTuple{(),Tuple{}}}, ::Mimi.ComponentInstanceParameters{NamedTuple{(),Tuple{}}}, ::Int64, ::Int64, ::Symbol) at C:\Users\Cora\.julia\packages\Mimi\R2d8T\src\core\types.jl:360
 [3] build(::Mimi.ModelDef) at C:\Users\Cora\.julia\packages\Mimi\R2d8T\src\core\build.jl:161
 [4] build at C:\Users\Cora\.julia\packages\Mimi\R2d8T\src\core\build.jl:90 [inlined]
 [5] #run#114(::Int64, ::Nothing, ::Function, ::Model) at C:\Users\Cora\.julia\packages\Mimi\R2d8T\src\core\model.jl:395
 [6] run(::Model) at C:\Users\Cora\.julia\packages\Mimi\R2d8T\src\core\model.jl:390
 [7] top-level scope at none:0
 [8] include_string(::Module, ::String, ::String) at .\loading.jl:1008
 [9] (::getfield(Main._vscodeserver, Symbol("##8#10")){String,Int64,Int64,String})() at c:\Users\Cora\.vscode\extensions\julialang.language-julia-0.12.0\scripts\terminalserver\terminalserver.jl:153
 [10] hideprompt(::getfield(Main._vscodeserver, Symbol("##8#10")){String,Int64,Int64,String}) at c:\Users\Cora\.vscode\extensions\julialang.language-julia-0.12.0\scripts\terminalserver\repl.jl:28
 [11] macro expansion at c:\Users\Cora\.vscode\extensions\julialang.language-julia-0.12.0\scripts\terminalserver\terminalserver.jl:148 [inlined]

[corakingdon]

@davidanthoff We discussed last week that my interim solution of just having the comp_id hold the actual module might be problematic in the case of re-defining components. I want to make sure I'm clear on what we want the functionality to be. With the following example:

using Mimi

# First definition of module foo (and component c.foo)
module foo
using Mimi
@defcomp c begin
    function run_timestep(p,v,d,t)
        println("first definition")
    end
end
end

m = Model()
set_dimension!(m, :time, 1:1)
add_comp!(m, foo.c)
println("Run 1:")
run(m)

# Second definition of module foo (and component c.foo)
module foo
using Mimi
@defcomp c begin
    function run_timestep(p,v,d,t)
        println("second definition")
    end
end
end

Mimi.build(m)   # Rebuild the same model 
println("Run 2:")
run(m)  # Still prints "first definition". Is this not the desired functionality?

m = Model()
set_dimension!(m, :time, 1:1)
add_comp!(m, foo.c)
println("Run 3:")
run(m)  # This prints "second definition"

In my current version of Mimi (where the actual module is stored in the component ID), the output from this example is:

Run 1:
first definition
WARNING: replacing module foo.
Run 2:
first definition
Run 3:
second definition

Is your desired functionality that the second run would use the re-defined component definition, even though the original component had already been added to the model? Or is it sufficient that the third run here uses the newly defined component definition?

[corakingdon]

decided Friday 9/6/19-- we will store the actual module for now.