Eliminate global comp dict #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rjplevin
commented
Mar 5, 2019
rjplevin
commented
- Eliminated global dict of component defs
- Fixed uses of eval to avoid precompilation issues
…e the defined ComponentDef rather than storing a ComponentId. - Updated all tests
- Replaced others with Base.eval(Main, expr)
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 81.33% 81.67% +0.33%
==========================================
Files 25 25
Lines 1897 1877 -20
==========================================
- Hits 1543 1533 -10
+ Misses 354 344 -10
Continue to review full report at Codecov.
|
davidanthoff
approved these changes
Mar 7, 2019
| function __init__() | ||
| compdir = joinpath(dirname(@__FILE__), "components") | ||
| compdir = joinpath(@__DIR__, "components") | ||
| load_comps(compdir) |
There was a problem hiding this comment.
Do we still need to do this in `init``? With these fixes, shouldn't we just be able to include these files in the normal way now? We don't have to change this in this PR, just wondering...
There was a problem hiding this comment.
Agreed. I quickly tried to change this but MimiDice2013 complained about loading Mimi from cache. Rather than debug this now, I'll merge what we have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.