Remove some dependencies #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidanthoff
commented
Apr 30, 2019
| # | ||
| column_names(iter::SimIterator) = column_names(iter.sim) | ||
| column_types(iter::SimIterator) = IterableTables.column_types(iter.sim) | ||
| column_types(iter::SimIterator) = error("Not implemented") # Used to be `IterableTables.column_types(iter.sim)` |
There was a problem hiding this comment.
@rjplevin the old code can not have worked because the column_types function was removed when we moved to julia 1.0. I assume this is just not used, given that no tests fail?
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 83.29% 83.29%
=======================================
Files 26 26
Lines 1868 1868
=======================================
Hits 1556 1556
Misses 312 312
Continue to review full report at Codecov.
|
lrennels
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some unnecessary dependencies, and marks some of them as only needed for testing. Overall this should make installation of the package lighter weight and improve load times of the package.