Skip to content

Conversation

corakingdon
Copy link
Collaborator

Copy link
Collaborator

@rjplevin rjplevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we're considering restoring these @warn calls, there's no need to keep the test_log stuff. Also, if we're not issuing warnings on things like redefinitions, there's little point in keeping the calls. @warn is user-oriented, while @debug is developer-oriented. For this reason I wonder if it ever makes sense to change @warn to @debug. @davidanthoff -- what do you think?

Copy link
Collaborator

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of merging as is for now.

We can revisit the issue of verbose mode later. I looked a bit into the logging infrastructure, and I think it would be fairly simple to use that for our needs. But after the workshop :)

@ckingdon95 do you want to merge this one here once you are sure that it is ready?

@davidanthoff davidanthoff merged commit 8b96b3c into master May 23, 2019
@davidanthoff davidanthoff deleted the warnings branch May 23, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants