Skip to content

Conversation

lrennels
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current syntax there is wrong, I left a comment for the first example, but the same applies to all those cases.

README.md Outdated
Pkg.add("Mimi")
````
```julia
pkg> add("Mimi")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pkg> add Mimi

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry was moving too fast ...

@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #483 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files          26       26           
  Lines        1870     1870           
=======================================
  Hits         1557     1557           
  Misses        313      313

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89cd2bc...71795ea. Read the comment docs.

@lrennels lrennels requested a review from davidanthoff May 16, 2019 20:25

```julia
julia> Pkg.update()
pkg> update()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also, remove the parenthesis.

@lrennels lrennels requested a review from davidanthoff May 20, 2019 20:46
@lrennels lrennels merged commit 6ef192a into master May 20, 2019
@lrennels lrennels deleted the pkgmode branch May 20, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants