-
Notifications
You must be signed in to change notification settings - Fork 35
Add "show" method for Model #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Does this print out all internal and external parameter connections? won't this still be a bit unwieldy? |
Feel free to dial it back if needed. This is what it looks like with a simple test model:
|
This is what it looks like for MimiFUND, and depending on whether or not your console does line wrap (mine does) it appears even longer. I don't really have a preference, and I do think this is descriptive and useful, just wanted to check if this is what @davidanthoff wants since it is still a huge wall of text
|
On one hand it is a lot of text, but it seems that unless we remove some of the (in my opinion) more vital and interesting information on connections and settings, we will have to expect the |
Yeah. I agree that the old way was undecipherable (the term "wall of text" is apparently subjective. ;~) |
Though, I'll add that the effect is not nearly so nice with text wrapping! |
This is a far more organized and well-structured "wall" ... instead of a big old undecipherable "block" |
Hm, I'm tempted to think that maybe the default should only show the components? I think having a default that is relatively short is useful. Would be nice to also have the option to get the full output, because agreed it is very useful. It is not clear to me what a canonical API design in julia is for this situation. I think what would be good for the workshop is if showing a model in a Jupyter notebook doesn't take up a whole screen... |
It looks like the 3-arg form of The version I'm about to push does the following. For display of a result in the REPL:
When calling
I'm not sure
|
#485