Class based #556
Merged
Class based #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a expression to insert)
…t, e.g., "/my/comp/path:datum" in set_param! and connect_param!.
…omponentDef - Add getindex/setindex/haskey for CompositeComponentDef's to operate on namespace rather than always assuming this identifies a sub-comp.
…nd for making connections in @defcomposite
- Move dimensions-related code to separate file - Replace numcomponents() with length()
# Conflicts: # src/core/build.jl # src/core/connections.jl # src/core/defs.jl # src/core/model.jl # src/core/time.jl # src/core/types.jl # test/test_getdataframe.jl # test/test_parametertypes.jl # test/test_timesteps.jl
…gle namespace dictionary instead, and modified several methods to accommodate this change. The methods param_dict() and var_dict() are used to produce these type-specific lists. - All tests currently passing.
…of pairs of the form name-in-subcomponent => name-in-composite. Note that this feature is not completely implemented yet and needs to be compatible with the new semantics in @defcomposite.
…ined in @defcomposite. - All tests are passing again.
# Conflicts: # src/Mimi.jl # src/core/defcomp.jl # src/core/defs.jl # src/core/model.jl # src/core/time.jl # src/core/types.jl # src/explorer/buildspecs.jl # src/mcs/defmcs.jl # src/mcs/mcs.jl # src/mcs/montecarlo.jl # src/utils/getdataframe.jl # test/mcs/test_defmcs.jl # test/test_explorer_model.jl # test/test_metainfo.jl # test/test_metainfo_variabletimestep.jl
…ext: test all models.
|
I think the next step here is to modify https://github.com/mimiframework/Mimi.jl/blob/master/test/dependencies/run_dependency_tests.jl such that it uses a branch of FUND that works with this version of Mimi.jl. I think simply replacing the second element in the tuple that is currently a version string should do the trick. Or, alternatively we merge the FUND branch, tag a new release, and then also update that file here to pick up the newer version. |
davidanthoff
approved these changes
Oct 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 84.06% 77.22% -6.84%
==========================================
Files 27 39 +12
Lines 2146 2582 +436
==========================================
+ Hits 1804 1994 +190
- Misses 342 588 +246
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long awaited composite mega-super-mondo-merge.