Explorer for Composite Components #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrennels
commented
Jun 2, 2020
| Return a DatumDef for `item` in the given component `comp_def`. | ||
| """ | ||
| function datumdef(comp_def::ComponentDef, item::Symbol) | ||
| function datumdef(comp_def::AbstractComponentDef, item::Symbol) |
There was a problem hiding this comment.
@ckingdon95 do you see a downside to doing it this way (generalizing to one signature for all AbstractComponentDef types instead of making a separate method for a CompositeComponentDef? All tests pass, but you have a better sense of the theory behind this so I want to make sure I'm not breaking something.
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
+ Coverage 80.05% 80.16% +0.10%
==========================================
Files 38 38
Lines 2858 2858
==========================================
+ Hits 2288 2291 +3
+ Misses 570 567 -3
Continue to review full report at Codecov.
|
davidanthoff
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make small changes to allow a call to
explore(m)on a model that contains composite components. For now this will only display the namespaces of the top level components, and will not dive into the sub-components of a composite component.#711