Move explorer to use React #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=======================================
Coverage 78.73% 78.74%
=======================================
Files 35 35
Lines 2996 3044 +48
=======================================
+ Hits 2359 2397 +38
- Misses 637 647 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ponent def, but makes the explorer error out
lrennels
reviewed
Oct 7, 2020
There was a problem hiding this comment.
@arnavgautam this is looking great! I made a few comments and will now push a PR addressing them. I can also work on adding more tests for the functions we are adding.
lrennels
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arnavgautam I think we're close here! I did two main things,
(1) added a bunch of CSS to our work to mesh with what Material UI does (I put some links in the top of the CSS file for notes on where I found info)
(2) did a very preliminary Material UI theme adoption to get the font size down (https://codesandbox.io/s/l48vjmk3om?file=/index.js; https://codesandbox.io/s/l48vjmk3om?file=/index.js) but this could probably be a lot more elegant :)
Some potential TODOs:
make the data view list item go blue or orange when selected (we'd have to change them from list items to buttons or something (probably not worth too much effort on this first pass we can just make it a TODO for later especially since the graph title makes it clear what is selected)
decide if we want the scroll bars to be always visible (that's the current state, see top of the CSS file)
alter Material UI in a more elegant way ... although I don't really feel motivated to do this right now since it looks good as is ...
any other changes you think would make it look better! We can show it at the meeting and see if people want something different!