Change deprecation warning to error for sim instance access methods #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
- Coverage 80.64% 80.62% -0.02%
==========================================
Files 38 38
Lines 2867 2844 -23
==========================================
- Hits 2312 2293 -19
+ Misses 555 551 -4
Continue to review full report at Codecov.
|
davidanthoff
approved these changes
Jul 14, 2020
davidanthoff
previously requested changes
Jul 14, 2020
src/mcs/mcs_types.jl
Outdated
| msg = "getindex method for `SimulationInstance` has been replaced with getdataframe function for consistency of return type, please use getdataframe instead" | ||
| Base.depwarn("$msg, $(stacktrace())", :getindex) | ||
| return sim_inst.results[model][(comp_name, datum_name)] | ||
| error("$msg") |
There was a problem hiding this comment.
Suggested change
| error("$msg") | |
| error(msg) |
:) Or don't use a local var at all and just pass the string directly to error.
There was a problem hiding this comment.
All relics of older more complex messages from depreciations :) ... I’ll go through these today
corakingdon
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecation warning needs to be an error for v1.0.0, I noticed this when working on PAGE.