Remove plot_comp_graph #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 80.62% 80.81% +0.19%
==========================================
Files 38 36 -2
Lines 2844 2815 -29
==========================================
- Hits 2293 2275 -18
+ Misses 551 540 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
corakingdon
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
plot_comp_graphfunction was disabled when we removed theCairodependency, so this was a bug. We decided to remove the function altogether, along with theComposedependency, for simplicity and because this graph doesn't work well with complicated models anyways. In the future we could replace it with something in VegaLite.Removing this function (in addition to disabling automatic component ordering in v0.5) makes all of the functions in
order.jlunused. I have thus removed that file as well. In the future if we want to pull back some of this ordering we can go grab those files but for now they seem like dead code ... @davidanthoff @ckingdon95 agreed?