Skip to content

Parameterization with Package (ie. Distributions) #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 11, 2020
Merged

Parameterization with Package (ie. Distributions) #757

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
51407b9
Add a TODO comment
lrennels Sep 10, 2020
8d3b44b
Try @__MODULE__ macro; add wip file
lrennels Sep 10, 2020
e3e1daf
Edit wip file
lrennels Sep 10, 2020
7c6e95e
Revert change
lrennels Sep 10, 2020
5be6ba2
Merge branch 'master' into eval-distributions
lrennels Sep 10, 2020
64f1ea1
Change module for @defcomp eval
lrennels Sep 11, 2020
435763f
Pass symbol instead of eval in defcomp
lrennels Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/core/defcomp.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,10 @@ macro defcomp(comp_name, ex)
end
end

datum_type = (datum_type === nothing ? Number : Main.eval(datum_type))
@debug "before: datum type is $datum_type, which is of type $(typeof(datum_type))"
datum_type = (datum_type === nothing ? :Number : datum_type)
@debug "after: datum type is $datum_type, which is of type $(typeof(datum_type))"

addexpr(_generate_var_or_param(elt_type, name, datum_type, dimensions, dflt, desc, unit))

else
Expand Down