Review Treatment of TimestepArrays #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
==========================================
+ Coverage 78.70% 78.74% +0.03%
==========================================
Files 35 35
Lines 2968 2973 +5
==========================================
+ Hits 2336 2341 +5
Misses 632 632
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This will fix the specific issue cited ... I'll add an issue to make this more robust in the future. |
lrennels
changed the title
davidanthoff
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is to work on #748
It is fixed for the specific case @davidanthoff pointed out but really should be expanded to handle some other indexing cases ... I'm hoping there's a simpler way than writing all these cases into
dotviewbut having trouble finding documentation on whatdotviewcallsupdate we should pause now and take a closer look at how we could possible remove any overrides of
dot viewin favor for a more conventional approach of addingaxesin conjunction withgetindexandsetindex!methods ... and understand better the conventional way of doing this work