Skip to content

Conversation

lrennels
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #763 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   78.74%   78.70%   -0.05%     
==========================================
  Files          35       35              
  Lines        2969     2968       -1     
==========================================
- Hits         2338     2336       -2     
- Misses        631      632       +1     
Flag Coverage Δ
#unittests 78.70% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/defcomp.jl 81.65% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a2cf9...f9cae68. Read the comment docs.

@lrennels lrennels marked this pull request as ready for review September 24, 2020 18:49
@lrennels
Copy link
Collaborator Author

@ckingdon95 just some code to clean up some warnings, I think the code coverage change is erroneous since I really didn't change much but will address that in my code coverage branch if needed

@lrennels
Copy link
Collaborator Author

@davidanthoff turns out to be a small PR since the main error was in Electron.jl but this will clean things up nonetheless

@lrennels lrennels merged commit 4d89d02 into master Sep 29, 2020
@lrennels lrennels deleted the explorer-bugfix branch September 29, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants