Skip to content

Conversation

jmwingenroth
Copy link
Collaborator

@jmwingenroth jmwingenroth commented Jan 27, 2021

Hello!

My name is Jordan, and I'm new on this project. I met with @davidanthoff on Monday and he set me loose on the issue stack.

Edit: Here, I fixed a few grammatical issues, then set up a test to improve code coverage. I intended this mostly as an introduction and a hands-on way to begin to familiarize myself with Mimi's code.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #792 (5382421) into master (24e61f5) will increase coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
+ Coverage   78.77%   78.83%   +0.05%     
==========================================
  Files          35       35              
  Lines        3062     3061       -1     
==========================================
+ Hits         2412     2413       +1     
+ Misses        650      648       -2     
Flag Coverage Δ
unittests 78.83% <80.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/connections.jl 85.40% <0.00%> (ø)
src/core/defcomposite.jl 89.52% <0.00%> (ø)
src/core/build.jl 100.00% <100.00%> (ø)
src/core/defcomp.jl 82.24% <100.00%> (ø)
src/core/defs.jl 82.96% <100.00%> (+0.27%) ⬆️
src/core/references.jl 65.38% <100.00%> (ø)
src/utils/getdataframe.jl 75.29% <100.00%> (ø)
src/core/delegate.jl 91.66% <0.00%> (+3.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e61f5...5382421. Read the comment docs.

@jmwingenroth jmwingenroth changed the title minor: error message grammar consistency minor: grammar and typos Jan 27, 2021
@jmwingenroth jmwingenroth changed the title minor: grammar and typos Standardizes error message grammar, adds test for bad composite parameters Jan 28, 2021
@jmwingenroth jmwingenroth changed the title Standardizes error message grammar, adds test for bad composite parameters Standardize error message grammar, add test for bad composite parameters Jan 28, 2021
@jmwingenroth jmwingenroth changed the title Standardize error message grammar, add test for bad composite parameters Standardize error message grammar, add test for bad composite parameters, fix a few other grammar things Jan 28, 2021
@lrennels
Copy link
Collaborator

Great! Welcome @wingfactor I can take a look at this on Monday, happy to see you digging your hands in!

@lrennels lrennels self-requested a review January 31, 2021 18:39
@lrennels
Copy link
Collaborator

lrennels commented Feb 5, 2021

@wingfactor would you like me to merge this or would you rather keep it open for a while as your learning branch?

@jmwingenroth
Copy link
Collaborator Author

@lrennels You can go ahead and merge it, thank you for checking. I've got a fork of the project to keep experimenting with and to submit future pull requests from.

@lrennels lrennels merged commit bce4274 into mimiframework:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants