Skip to content

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Mar 7, 2021

No description provided.

@lrennels lrennels changed the title Change backup size requireemnts to match model time; Change keyword a… updates to connector Mar 7, 2021
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #798 (c92ea15) into master (9ba6c74) will increase coverage by 0.21%.
The diff coverage is 98.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   80.37%   80.59%   +0.21%     
==========================================
  Files          37       37              
  Lines        3053     3066      +13     
==========================================
+ Hits         2454     2471      +17     
+ Misses        599      595       -4     
Flag Coverage Δ
unittests 80.59% <98.14%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/paths.jl 80.28% <ø> (ø)
src/core/connections.jl 87.11% <93.75%> (+0.23%) ⬆️
src/core/build.jl 100.00% <100.00%> (ø)
src/core/defcomposite.jl 90.17% <100.00%> (+0.65%) ⬆️
src/core/defs.jl 86.07% <100.00%> (+1.50%) ⬆️
src/core/dimensions.jl 84.21% <100.00%> (ø)
src/core/model.jl 84.21% <100.00%> (ø)
src/core/types/params.jl 61.90% <100.00%> (ø)
src/core/defcomp.jl 81.28% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba6c74...c92ea15. Read the comment docs.

@lrennels lrennels marked this pull request as ready for review March 7, 2021 23:59
@lrennels lrennels requested a review from arnavgautam March 8, 2021 04:30
@lrennels lrennels changed the title updates to connector updates to connector and add first/last for composites Mar 10, 2021
@lrennels lrennels merged commit 436fbd9 into master Mar 16, 2021
@lrennels lrennels deleted the connector branch March 16, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants