Skip to content

Conversation

lrennels
Copy link
Collaborator

@lrennels lrennels commented Jul 14, 2021

This PR adds a warning if a user uses the compname.paramname = Distribution syntax for a component parameter linked to a shared parameter. This should be a warning, if not an error, because it may look as if the user is varying just that component's parameter, but this will vary the shared parameter and thus all parameters connected to that shared parameter. The TODOs here are

  • add the warning
  • test the warning

@lrennels
Copy link
Collaborator Author

#838

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #839 (8d13164) into master (050eadf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
+ Coverage   84.25%   84.27%   +0.01%     
==========================================
  Files          40       40              
  Lines        3780     3783       +3     
==========================================
+ Hits         3185     3188       +3     
  Misses        595      595              
Flag Coverage Δ
unittests 84.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mcs/montecarlo.jl 88.06% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050eadf...8d13164. Read the comment docs.

@lrennels lrennels merged commit c714cd4 into master Jul 28, 2021
@lrennels lrennels deleted the mcs-bug branch July 28, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants