Add set param methods for model instances #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 84.27% 84.28%
=======================================
Files 40 40
Lines 3783 3785 +2
=======================================
+ Hits 3188 3190 +2
Misses 595 595
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@davidanthoff @jmwingenroth can someone approve this? It's a follow up to the big set and update parameters update we did, just putting up some more safety barriers for people using this function (which is a speedup backdoor that only Frank and Tony use right now anyways) |
jmwingenroth
approved these changes
Sep 17, 2021
Comment on lines
+828
to
+830
| is_shared(param) && error("$comp_name:$param_name is connected to a ", | ||
| "a shared model parameter with name $model_param_name in the model, ", | ||
| "to update the shared model parameter please call `update_param!(mi, $model_param_name, value)` ", |
There was a problem hiding this comment.
Suggested change
| is_shared(param) && error("$comp_name:$param_name is connected to a ", | |
| "a shared model parameter with name $model_param_name in the model, ", | |
| "to update the shared model parameter please call `update_param!(mi, $model_param_name, value)` ", | |
| is_shared(param) && error("$comp_name:$param_name is connected to", | |
| "a shared model parameter with name $model_param_name in the model.", | |
| "To update the shared model parameter, please call `update_param!(mi, $model_param_name, value)` ", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.