Skip to content

Fix bug in type checking #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Fix bug in type checking #843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
885a827
Fix bug in type checking
lrennels Sep 22, 2021
94b2504
Merge branch 'master' into units-bug
lrennels Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/core/connections.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,14 @@ function _check_attributes(obj::AbstractCompositeComponentDef,

param_def = parameter(comp_def, param_name)

# handle string case
t1 = eltype(mod_param.values)
t2 = eltype(param_def.datatype)

# handle String case
if t1 == Char; t1 = String; end
if t2 == Char; t2 = String; end

if !(t1 <: Union{Missing, t2})
error("Mismatched datatype of parameter connection: Component: $(nameof(comp_def)) ",
"Parameter: $param_name ($t2) to Model Parameter ($t1). Mimi requires that ",
Expand Down