Enable Rubocop #696
Merged
Enable Rubocop #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovro-bikic
commented
Aug 19, 2021
| @@ -10,7 +12,7 @@ | |||
|
|
|||
| outfile = './config/deploy.rb' | |||
|
|
|||
| if File.exists?(outfile) | |||
| if File.exist?(outfile) | |||
There was a problem hiding this comment.
File.exists? is deprecated in favor of File.exist?
d4be4st
approved these changes
Aug 19, 2021
lovro-bikic
force-pushed
the
feature/enable-rubocop
branch
from
a30318e
to
f4872f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Rubocop again. The old
.rubocop.ymlwas deleted and I ranbundle exec rubocop --auto-gen-configto autogenerate a new TODO config. One by one, I removed cops from the TODO config and fixed offenses where necessary. I also disabled some cops because they don't apply to this project.Rubocop was also enabled as a required step on CI.