Skip to content

Conversation

ea-rus
Copy link
Collaborator

@ea-rus ea-rus commented Jul 26, 2024

After decoupling agent from langchain handler mindsdb langchain model is not required for agent.
In this PR automatic model creation is removed.

Agent can be used as:

agent=connection.agents.create('my_agent', skills=['my_skill'], prompt_template='Answer the user input in a helpful way')

# or with default prompt template
agent=connection.agents.create('my_agent', skills=['my_skill'])

dependent on mindsdb/mindsdb#9525

@ea-rus ea-rus requested a review from tmichaeldb July 26, 2024 08:18
Copy link

github-actions bot commented Jul 26, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2095275%33, 100, 103, 111, 119, 127, 135, 145, 148, 152, 154, 156, 158, 160, 162, 221, 234, 238–253, 265, 274–278, 285–286, 323, 335–336, 377, 425–426, 429, 436, 457–459, 463–467
   databases.py45296%109, 137
   handlers.py39197%77
   jobs.py97793%41, 53, 81, 85, 147–150
   knowledge_bases.py1261588%58–61, 151, 155–162, 167–171, 250–253, 322, 339
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py63198%160
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2244281%19–29, 35–36, 51, 54–55, 75–77, 98, 101, 108–111, 144–152, 173–174, 209–212, 226–227, 281–286
mindsdb_sdk/utils
   mind.py37370%1–102
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL151925183% 

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 9.633s ⏱️

params.update(kwargs)

if 'prompt_template' not in params:
params['prompt_template'] = 'Answer the user"s question in a helpful way: {{question}}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default template would be better as a named constant

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ea-rus
Copy link
Collaborator Author

ea-rus commented Jul 29, 2024

I don't merge this PR because we can't release sdk before mindsdb part is released

@ea-rus ea-rus merged commit 09aeac4 into staging Jul 31, 2024
@ea-rus ea-rus mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

2 participants