Skip to content

Conversation

ea-rus
Copy link
Collaborator

@ea-rus ea-rus commented Jul 29, 2024

Changed way of using skills and agents collections:
Instead of passing required objects to constructor - use parent collection to get them.

Fix: mindsdb/mindsdb#9561

@ea-rus ea-rus requested a review from dusvyat July 29, 2024 17:48
Copy link

github-actions bot commented Jul 29, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2075275%33, 101, 104, 112, 120, 128, 136, 146, 149, 153, 155, 157, 159, 161, 163, 225, 238, 242–257, 269, 278–282, 289–290, 326, 338–339, 380, 429–430, 433, 440, 461–463, 467–471
   databases.py45296%109, 137
   handlers.py39197%77
   jobs.py97793%41, 53, 81, 85, 147–150
   knowledge_bases.py1261588%58–61, 151, 155–162, 167–171, 250–253, 322, 339
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py64198%160
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2244281%19–29, 35–36, 51, 54–55, 75–77, 98, 101, 108–111, 144–152, 173–174, 209–212, 226–227, 281–286
mindsdb_sdk/utils
   mind.py37370%1–102
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL151725183% 

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 9.821s ⏱️

Copy link
Contributor

@dusvyat dusvyat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the conflict, otherwise looks good to me

@ea-rus ea-rus changed the title Updated agents and skills collection Polished agents and skills collection Jul 30, 2024
@ea-rus ea-rus merged commit b0251bd into staging Jul 31, 2024
@ea-rus ea-rus mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

[Bug]: Agent failed error
2 participants