Skip to content

Conversation

tmichaeldb
Copy link
Contributor

KB names are used as vector DB collection names. URLs with bad characters can cause the underlying vector DB queries to fail.

So, we should just not use them at all since the actual semantics of KB names aren't that important.

@tmichaeldb tmichaeldb merged commit c010959 into main Aug 26, 2024
5 checks passed
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sdk
   agents.py2035274%33, 101, 104, 112, 120, 138, 156, 166, 169, 173, 175, 177, 179, 181, 183, 245, 258, 262–277, 289, 298–302, 309–310, 356, 364–365, 415, 464–465, 468, 475, 496–498, 502–506
   databases.py45296%109, 137
   handlers.py39197%77
   jobs.py97793%41, 53, 81, 85, 147–150
   knowledge_bases.py1261588%58–61, 155, 159–166, 171–175, 254–257, 326, 343
   ml_engines.py42393%94, 126, 128
   models.py2101991%109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
   projects.py64198%160
   query.py13192%14
   skills.py53394%43, 45, 49
   tables.py1301588%140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
   views.py37295%105, 138
mindsdb_sdk/connectors
   rest_api.py2254281%19–29, 35–36, 51, 54–55, 75–77, 98, 101, 108–111, 144–152, 173–174, 209–212, 226–227, 281–286
mindsdb_sdk/utils
   mind.py41410%1–119
   openai.py853065%37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
   table_schema.py21210%1–54
TOTAL151825583% 

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 10.042s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: merged
Development

Successfully merging this pull request may close these issues.

1 participant