Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel description improvements 2. #121

Merged
merged 14 commits into from Mar 13, 2018

Conversation

Projects
None yet
6 participants
@Megaf
Copy link
Contributor

commented Mar 7, 2018

Making all channels match code style and text formatting.
Adding a more direct and clear description to each channel.
Making use of uppercase for aesthetics and to make things more relevant.
Adding webchat for Minetest-Hub. In the topic of the channel we have a link for the channels website and it also says about voice and asking an op for it.
Adding webchat for Minetest-Hub. Mainly to match style.

Opinions needed.

[WIP] Channel description improvements 2.
Making all channels match code style and text formatting.
Adding a more direct and clear description to each channel.
Making use of uppercase for aesthetics and to make things more relevant.
Adding webchat for Minetest-Hub. In the topic of the channel we have a link for the channels website and it also says about voice and asking an op for it.
Adding webchat for Minetest-Hub. Mainly to match style.

Opinions needed.
irc.html Outdated
See <a href="http://hub.minetest.net/info">the channel's website</a> for more information.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#Minetest-Hub</a></strong>
(<a href="http://irc.minetest.net/minetest-hub">Logs</a>):
Community channel, to talk about modding, server adminitration and short off-topic.

This comment has been minimized.

Copy link
@Ezhh

Ezhh Mar 7, 2018

Member

The channel is not for offtopic; it's simply something we usually accept. I prefer the previous description for -hub, then adjust the other two so they are full sentences.

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 7, 2018

Author Contributor

And what about the description for the other channels?

@Ezhh

This comment has been minimized.

Copy link
Member

commented Mar 7, 2018

@Megaf You are pretty close already. #minetest needs a better description than we started with. Maybe instead of:
Main channel, where players can join to chat and get support about Minetest.
try:
Main channel where all players and contributors can discuss the game or request support.
(This is more inclusive, so I think it would be better.)

And for -dev, I'd suggest not replacing the current information (unless you can maybe think of a better term than "serious stuff"), but do fix the capitalisation ("development channel" to "Development channel") so it matches the others.

Megaf added some commits Mar 7, 2018

Update irc.html
Reverting Minetest-Hub description.
Improvements on Minetest description.
TODO on -Dev, we have to rephrase serious stuff.
Updated Minetest-Dev description.
Updated Minetest-Dev description.

@Megaf Megaf changed the title [WIP] Channel description improvements 2. Channel description improvements 2. Mar 7, 2018

@sofar

This comment has been minimized.

Copy link
Member

commented Mar 8, 2018

lgtm

irc.html Outdated
</strong>
(<a href="http://irc.minetest.net/minetest-dev">logs</a>):
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#Mminetest-Dev</a></strong>

This comment has been minimized.

Copy link
@sfan5

sfan5 Mar 9, 2018

Member

typo

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

Fixed

irc.html Outdated
(<a href="http://irc.minetest.net/minetest">logs</a>): main channel
<strong><a href="https://webchat.freenode.net/?channels=#minetest">#Minetest</a></strong>
(<a href="http://irc.minetest.net/minetest">Logs</a>):
Main channel where all players and contributors can discuss the game or request support.

This comment has been minimized.

Copy link
@sfan5

sfan5 Mar 9, 2018

Member

why explicitly name which group of people this channel for?

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

It was something we came with when discussing about it on #-dev. Do you have other suggestions?

irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#Mminetest-Dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
"Development channel, strictly engine or minetest_game development talk only; note that webchat is muted due to too much spam/flood."

This comment has been minimized.

Copy link
@sfan5

sfan5 Mar 9, 2018

Member

quotes not needed

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

Fixed

irc.html Outdated
(<a href="http://irc.minetest.net/minetest-hub">logs</a>):
A moderated channel for people who regularly improve Minetest by developing, modding, hosting servers and otherwise.
See <a href="http://hub.minetest.net/info">the channel's website</a> for more information.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#Minetest-Hub</a></strong>

This comment has been minimized.

Copy link
@sfan5

sfan5 Mar 9, 2018

Member

why is the channel name capitalized?
this does not reflect their actual names on IRC

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

Because Minetest is capitalised and on IRC is up to the IRC client and/or user to "decide" how to represent it. Besides, in my opinion it looks better and more serious when capitalised.

This comment has been minimized.

Copy link
@Ezhh

Ezhh Mar 9, 2018

Member

It's lower case on the official page: http://hub.minetest.net/info
So it needs to be lower case here.

This comment has been minimized.

Copy link
@paramat

paramat Mar 9, 2018

Member

Only lowercase makes sense, that is specifically the channel name.

This comment has been minimized.

Copy link
@sfan5

sfan5 Mar 9, 2018

Member

in case it matters: the IRC specification does not mention channel names being case-insensitive, so #minetest and #Minetest might in theory be totally different channels

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

Roger.

Megaf added some commits Mar 9, 2018

irc.html Outdated
(<a href="http://irc.minetest.net/minetest">logs</a>): main channel
<strong><a href="https://webchat.freenode.net/?channels=#minetest">#Minetest</a></strong>
(<a href="http://irc.minetest.net/minetest">Logs</a>):
Main channel where everyone is welcome to discuss the game or request support.

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

Is this description any better?

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

Might change it to "Main channel for general game and engine discussion or support" in the next commit tho.

This comment has been minimized.

Copy link
@paramat

paramat Mar 9, 2018

Member

Remember MT is not a 'game', better to refer to 'Minetest engine' and 'games' (plural) as other games can be discussed.

This comment has been minimized.

Copy link
@paramat

paramat Mar 9, 2018

Member

I agree that 'everyone is welcome' is not needed.

irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#Minetest-Dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly engine or minetest_game development talk only; note that webchat is muted due to too much spam/flood.

This comment has been minimized.

Copy link
@paramat

paramat Mar 9, 2018

Member

Line too long in code, can it be split? I assume it auto-wraps when displayed on the webpage.

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

A web browser will indeed auto-wrap, so I wouldn't worry much about long line.

This comment has been minimized.

Copy link
@paramat

paramat Mar 9, 2018

Member

I mean, long line is best avoided in the code, if possible.

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 10, 2018

Author Contributor

@paramat Better? And at least least nothing changed visually on Safari, just the editing in a console window gets easier with the line break indeed.

irc.html Outdated
See <a href="http://hub.minetest.net/info">the channel's website</a> for more information.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#Minetest-Hub</a></strong>
(<a href="http://irc.minetest.net/minetest-hub">Logs</a>):
A moderated channel for people who regularly improve Minetest by developing, modding, hosting servers and otherwise.

This comment has been minimized.

Copy link
@paramat

paramat Mar 9, 2018

Member

As above, if possible split long line in code.

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 9, 2018

Author Contributor

As above.

Megaf added some commits Mar 9, 2018

Update channel descriptions.
Decapitalised channel names.
Change in #minetest description.
Added line breaks in the code.
I broke the line so they we can see the whole line in a standard terminal window using a text editor like nano or vi.

@sfan5 sfan5 dismissed a stale review Mar 10, 2018

.

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2018

So, what about we keep the link to web chats and add a note like so.
screen shot 2018-03-10 at 12 28 51

<div>
  <p>
    Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
    Please note that in order to chat on #minetest-hub you need to
    ask an operator for voice and to chat on #minetest-dev you 
    need to be using a real IRC client.<br>
  </p>
  <ul>
    <li>
      <strong><a href="https://webchat.freenode.net/?channels=#minetest">#minetest</a></strong>
        (<a href="http://irc.minetest.net/minetest">Logs</a>):
        Main channel for general Minetest engine and games discussion or
        support.
    </li>
    
    <li>
      <strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
        (<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
        Development channel, strictly engine or minetest_game development
        talk only.
    </li>
    
    <li>
      <strong><a href="https://webchat.freenode.net/?channels=#minetest-hub">#minetest-hub</a></strong>
        (<a href="http://irc.minetest.net/minetest-hub">Logs</a>):
        A moderated channel for people who regularly improve Minetest
        by developing, modding, hosting servers and otherwise.
    </li>
  </ul>
</div>
Line breaks and short notice about web chat.
Added a short notice about how to chat on -hub and -dev before the list of channels.
Keeping web chat links
irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly engine or minetest_game development

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

Maybe 'Minetest engine' here for consistency with the above?

This comment has been minimized.

Copy link
@rubenwardy

rubenwardy Mar 12, 2018

Member

or

strictly for discussions of <a href="https://github.com/minetest">official projects'</a> development
irc.html Outdated
@@ -10,24 +10,30 @@ <h1>Channels</h1>
<div>
<p>
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
Please note that in order to chat on #minetest-hub you need to
ask an operator for voice and to chat on #minetest-dev you

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

Long sentence, perhaps:
ask an operator for voice, to chat on #minetest-dev you
?

@paramat

This comment has been minimized.

Copy link
Member

commented Mar 12, 2018

Fine apart from my line comments.

Megaf added some commits Mar 12, 2018

irc.html Outdated
@@ -10,6 +10,9 @@ <h1>Channels</h1>
<div>
<p>
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
Please note that in order to chat on #minetest-hub you need to
ask an operator for voice and to chat on #minetest-dev you
need to be using a real IRC client.<br>

This comment has been minimized.

Copy link
@sfan5

sfan5 Mar 12, 2018

Member

instead of saying "you need a real irc client" just say that you "can't use webchat on -dev"

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 12, 2018

Author Contributor
  <p>
    Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
    To chat on #minetest-hub you need to ask an operator for voice. You can't you the webchat on #minetest-dev.<br>
  </p>

Good?

This comment has been minimized.

Copy link
@sfan5

sfan5 Mar 12, 2018

Member

s/can't you/can't use/
yes

@sfan5

sfan5 approved these changes Mar 12, 2018

irc.html Outdated
@@ -10,24 +10,28 @@ <h1>Channels</h1>
<div>
<p>
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
To chat on #minetest-hub you need to ask an operator for voice. You can't use the webchat on #minetest-dev.<br>

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

You can't use webchat on #minetest-dev
No need for 'the'

irc.html Outdated
</p>
<ul>
<li>
<strong><a href="https://webchat.freenode.net/?channels=#minetest">#minetest</a></strong>
(<a href="http://irc.minetest.net/minetest">logs</a>): main channel
(<a href="http://irc.minetest.net/minetest">Logs</a>):
Main channel for general Minetest engine and games discussion or

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

Almost suggests modding can't be discussed here.
Main channel for general Minetest engine, modding and games discussion or support.

irc.html Outdated
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly for discussions of <a href="https://github.com/minetest">official projects'</a> development.
talk only.

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

Makes no sense.
strictly only for discussions of <a href="https://github.com/minetest">official projects'</a> development.

irc.html Outdated
development channel, only serious stuff; note that webchat is muted due to too much spam/flood.
<strong><a href="https://webchat.freenode.net/?channels=#minetest-dev">#minetest-dev</a></strong>
(<a href="http://irc.minetest.net/minetest-dev">Logs</a>):
Development channel, strictly only for discussions of <a href="https://github.com/minetest">official projects'</a> development.

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

Hmm actually, linking to the homepage and calling that 'official projects' isn't descriptive, the home page doesn't have an 'official projects' section and what is official isn't obvious.
How about no link and describing what can be discussed (MTEngine, MTGame), as before?

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 12, 2018

Author Contributor

What was the old description again? Will see if I can find it easily

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

`..., strictly only for development discussion of the Minetest engine and Minetest Game'
'discussion' doesn't need to be plural.

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 12, 2018

Author Contributor

So, what about one of the description that we came with before.

Development channel, for topics related to bug reporting and general Minetest development.
@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2018

I think I have addressed everything by now.
Anything else?

irc.html Outdated
@@ -10,24 +10,26 @@ <h1>Channels</h1>
<div>
<p>
Join one of our <abbr title="Internet Relay Chat">IRC</abbr> channels on Freenode:<br/>
To chat on #minetest-hub you need to ask an operator for voice. You can't use webchat on #minetest-dev.<br>

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

Just one small thing, i think this sounds better, as a native English speaker:
Webchat cannot be used on #minetest-dev.

This comment has been minimized.

Copy link
@paramat

paramat Mar 12, 2018

Member

All else is fine for me.

This comment has been minimized.

Copy link
@Megaf

Megaf Mar 12, 2018

Author Contributor

Fantastic, I agree.

@Megaf

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2018

Done.

@paramat

This comment has been minimized.

Copy link
Member

commented Mar 12, 2018

👍 Text is ok for me.

@Ezhh

This comment has been minimized.

Copy link
Member

commented Mar 13, 2018

Fine by me 👍

@rubenwardy rubenwardy merged commit 79a98b5 into minetest:master Mar 13, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@Megaf Megaf deleted the Megaf:patch-1 branch Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.