Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the fsaa setting description #10279

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 9, 2020

This clarifies that Minetest needs to be restarted to see any changes.

See #8459.

To do

This PR is Ready for Review.

PS: Do I have to update minetest.conf.example and settings_translation_file.cpp myself? I couldn't get the generator to work locally.

How to test

Go to the Advanced Settings menu and check the FSAA description.

@paramat paramat added the @ Documentation Improvements or additions to documentation label Aug 10, 2020
@paramat
Copy link
Contributor

paramat commented Aug 10, 2020

Do I have to update minetest.conf.example and settings_translation_file.cpp myself?

No, we auto-generate those occasionally, so your work would be wasted effort if you did.

builtin/settingtypes.txt Outdated Show resolved Hide resolved
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SmallJoker SmallJoker merged commit aae7d4f into minetest:master Oct 6, 2020
JosiahWI pushed a commit to JosiahWI/minetest that referenced this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Documentation Improvements or additions to documentation >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants