Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove of unused history props #2122

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Remove of unused history props #2122

merged 2 commits into from
Jun 13, 2022

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jun 13, 2022

What does this do?

Remove of unused history props

Signed-off-by: Benjamin Perez benjamin@bexsoft.net

Remove of unused history props
cbfc191 
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft self-assigned this Jun 13, 2022
pjuarezd
pjuarezd reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@pjuarezd pjuarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woof

Well, it builds, and no longer yields the history field in js chunks, guess it's all good!?

@dvaldivia dvaldivia merged commit 4d876d0 into minio:master Jun 13, 2022
@dvaldivia dvaldivia deleted the remove-history-props branch June 13, 2022 23:41
@bexsoft
Copy link
Collaborator Author

bexsoft commented Jun 14, 2022

Woof Woof

Well, it builds, and no longer yields the history field in js chunks, guess it's all good!?

Haha, Yeah, if it works and not complains I think must be good xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjuarezd pjuarezd pjuarezd left review comments

@dvaldivia dvaldivia dvaldivia approved these changes

@reivaj05 reivaj05 reivaj05 approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

@cniackz cniackz Awaiting requested review from cniackz

@adfost adfost Awaiting requested review from adfost

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@bexsoft bexsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bexsoft @pjuarezd @reivaj05 @dvaldivia