Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to swagger TS API #2903

Merged
merged 19 commits into from
Jul 5, 2023
Merged

Refactor to swagger TS API #2903

merged 19 commits into from
Jul 5, 2023

Conversation

reivaj05
Copy link
Contributor

No description provided.

@reivaj05 reivaj05 self-assigned this Jun 22, 2023
bexsoft
bexsoft previously requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review Tags can be created and deleted test, seems like this is a real failure

@reivaj05 reivaj05 requested a review from bexsoft June 28, 2023 19:40
bexsoft
bexsoft previously requested changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of issues that need to verify if are related to this change:

Enabling Bucket encryption with wrong configuration doesn't throw an error

Screenshot 2023-06-28 at 14 56 31

Restart hangs and doesn't remove the top notification when completed:
Screenshot 2023-06-28 at 15 07 16

portal-ui/src/screens/Console/Common/FormComponents/RadioGroupSelector/RadioGroupSelector.tsx Outdated Show resolved Hide resolved
portal-ui/src/screens/Console/Configurations/TiersConfiguration/AddTierConfiguration.tsx Outdated Show resolved Hide resolved
@reivaj05 reivaj05 dismissed bexsoft’s stale review June 28, 2023 22:05

Address comments

@reivaj05 reivaj05 requested a review from bexsoft June 28, 2023 22:05
@reivaj05
Copy link
Contributor Author

@bexsoft issues fixed, the only one i wasn't able to reproduce was the issue with restarting, working fine for me

bexsoft
bexsoft previously approved these changes Jun 28, 2023
View reviewed changes
@cesnietor
Copy link
Collaborator

I just saw that the snack bar message doesn't show up when adding SSE-S3 encryption. It used to be shown.
before :
Screenshot 2023-07-05 at 1 44 44 PM
now:
Screenshot 2023-07-05 at 1 46 16 PM

@cesnietor
Copy link
Collaborator

I just debugged it a bit and is not being shown because error is null:
Screenshot 2023-07-05 at 3 34 43 PM

This is because of the following bug acacode/swagger-typescript-api#536 cc @bexsoft @reivaj05

@cesnietor cesnietor requested a review from bexsoft July 5, 2023 21:41
cesnietor
cesnietor approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit b31aa10 into minio:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexsoft bexsoft bexsoft approved these changes

@cesnietor cesnietor cesnietor approved these changes

@cniackz cniackz Awaiting requested review from cniackz

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@reivaj05 reivaj05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reivaj05 @cesnietor @bexsoft