Handle Invalid User error coming from madmin #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
reviewed
Oct 6, 2020
|
@cesnietor i tried but that error is an integer so it's hard to compare against as it gets transformed into a api response which makes the comparison harder |
harshavardhana
requested changes
Oct 6, 2020
Right now we display `Internal Server Error` when invalid credentials are presneted, this makes it so we only present `Unauthorized`
dvaldivia
force-pushed
the
handle-invalid-user-error
branch
from
e01b97d
to
79dffb9
Compare
bexsoft
approved these changes
Oct 6, 2020
harshavardhana
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we display
Internal Server Errorwhen invalid credentials are presneted, this makes it so we only presentUnauthorized