Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate console session when minio user doesn't exists #332

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Oct 19, 2020

Testing

  • Create new user and assign policy:
./mc admin user add orcadmin alevsk alevsk12356
./mc admin policy set orcadmin mcsAdmin user=alevsk
  • Login to console and list buckets/users/policies etc
  • Delete the user using mc
./mc admin user remove orcadmin alevsk
  • Try to navigate some more in Console, you should be redirected to the login screen since your session will be invalidated

Fixes #306

@Alevsk Alevsk self-assigned this Oct 19, 2020
@dvaldivia
Copy link
Collaborator

Will this log out the user on the UI?

dvaldivia
dvaldivia previously approved these changes Oct 19, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing.

@Alevsk
Copy link
Contributor Author

Alevsk commented Oct 19, 2020

Will this log out the user on the UI?

yes, in the UI user will be redirected to the login screen, we already have some logic to do that

cesnietor
cesnietor previously approved these changes Oct 19, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, just if the user is disabled it won't redirect to login page but as discussed previously this will be investigated.
LGTM.

@dvaldivia dvaldivia merged commit f6ac7e0 into minio:master Oct 19, 2020
@Alevsk Alevsk deleted the deleted-minio-user-session branch October 20, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logout users when the session is no longer valid
3 participants