Build assets inside the container #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
harshavardhana,
Alevsk,
cesnietor,
kaankabalak and
bexsoft
Alevsk
previously approved these changes
Oct 29, 2020
bexsoft
requested changes
Oct 30, 2020
There was a problem hiding this comment.
Please review an issue related with. seems like a socket is failing, I tried to re-execute flow and it didn't work
2020/10/29 16:35:44 error unexpected CloseError on ReadMessage: websocket: close 1006 (abnormal closure)
2020/10/29 16:35:44 error on ReadMessage: error
2020/10/29 16:35:44 closed conn.ReadMessage: websocket: close 1001 (going away)
--- PASS: TestWSHandle (0.00s)
FAIL
FAIL github.com/minio/console/restapi 12.961s
? github.com/minio/console/restapi/operations [no test files]
? github.com/minio/console/restapi/operations/admin_api [no test files]
? github.com/minio/console/restapi/operations/user_api [no test files]
FAIL
Makefile:53: recipe for target 'test' failed
make: *** [test] Error 1
Error: Process completed with exit code 2.```
|
@bexsoft the strange thing is that I didn't change code D: only updated the Go version |
Alevsk
previously approved these changes
Oct 30, 2020
bexsoft
previously approved these changes
Oct 30, 2020
dvaldivia
force-pushed
the
build-assets-in-docker
branch
from
2a1e47b
to
01e6609
Compare
Alevsk
previously approved these changes
Oct 31, 2020
harshavardhana
approved these changes
Oct 31, 2020
harshavardhana
requested changes
Oct 31, 2020
Alevsk
approved these changes
Nov 1, 2020
harshavardhana
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so the dockerfile builds the assets inside of it before compiling the final version of the container.
Also addresses #183