Connected Object details page to navigation #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
reviewed
Nov 16, 2020
dvaldivia
reviewed
Nov 16, 2020
dvaldivia
previously approved these changes
Nov 16, 2020
Alevsk
suggested changes
Nov 16, 2020
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ListObjects.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ObjectRouting.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ListObjects/ObjectRouting.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ObjectDetails/SetRetention.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+203
to
+209
| <MenuItem | ||
| value={option.value} | ||
| key={`select-${name}-${option.label}`} | ||
| > | ||
| {option.label} | ||
| </MenuItem> | ||
| ))} */} |
There was a problem hiding this comment.
This is going to be needed for next step of date selector
Comment on lines
+230
to
+236
| <MenuItem | ||
| value={option.value} | ||
| key={`select-${name}-${option.label}`} | ||
| > | ||
| {option.label} | ||
| </MenuItem> | ||
| ))} */} |
There was a problem hiding this comment.
This is going to be needed for next step of date selector
Connected Object details page to navigation schema. Also connected file details view with backend
bexsoft
force-pushed
the
object-details
branch
from
3ea35fb
to
7212b16
Compare
Alevsk
approved these changes
Nov 17, 2020
kaankabalak
approved these changes
Nov 17, 2020
|
tested LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Connected Object details page to navigation schema. Also connected file details view with backend
NOTE: There is a known issue on clicking back button / hot reload where information is not loaded on screen. Will adress this in the next PR