This repository has been archived by the owner on Jul 2, 2020. It is now read-only.
MCS add updateGroup and getGroupInfo admin api #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
approved these changes
Mar 19, 2020
| func setGroupStatus(client MinioAdmin, group, status string) error { | ||
| var setStatus madmin.GroupStatus | ||
| switch status { | ||
| case "enabled": |
There was a problem hiding this comment.
this is a good opportunity for a constant or an enum
There was a problem hiding this comment.
yes I thought about that mhmh but not sure if restrict it since minio might change the status
There was a problem hiding this comment.
will do if necessary in future
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update allows to update the members by either adding members or deleting members with a simple PUT operation.