This repository has been archived by the owner on Jul 2, 2020. It is now read-only.
[WIP] Login Page Restore #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 72de1b4.
dvaldivia
reviewed
Apr 2, 2020
| @@ -172,8 +172,9 @@ class Console extends React.Component< | |||
| .invoke("GET", `/api/v1/users/whoami`) | |||
| .then(res => {}) | |||
| .catch(err => { | |||
| storage.removeItem("token"); | |||
| history.push("/"); | |||
| // Commented this as whoami API is not available. This is a temporal fix for token dissapearing issue | |||
There was a problem hiding this comment.
I think we can entirely remove this until we figure out a way to validate the session
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR fixes the mcs Login page by changing the input fields for login page, updating login API & storing the new token in the local storage #383
NOTE: This PR requires #379 to be merged first