Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porting userCurrent from the minio project #1539

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

arschles
Copy link
Contributor

@arschles arschles commented Dec 9, 2015

I accidentally closed #1533, so this replaces it with a single commit.

@arschles
Copy link
Contributor Author

arschles commented Dec 9, 2015

cc/ @harshavardhana

@harshavardhana
Copy link
Member

This looks good to me. 👍

harshavardhana pushed a commit that referenced this pull request Dec 9, 2015
porting userCurrent from the minio project
@harshavardhana harshavardhana merged commit dfc0dc3 into minio:master Dec 9, 2015
@arschles
Copy link
Contributor Author

@harshavardhana this doesn't look to be in master at https://github.com/minio/mc/blob/master/utils.go. did it get moved in a more recent commit?

@harshavardhana
Copy link
Member

@harshavardhana this doesn't look to be in master at https://github.com/minio/mc/blob/master/utils.go. did it get moved in a more recent commit?

Yes i created a comprehensive package pkg/user which 'mc' inherits now. and uses 'user.Current()' - https://github.com/minio/minio/tree/master/pkg/user

@arschles
Copy link
Contributor Author

got it, thanks!

@harshavardhana
Copy link
Member

got it, thanks!

Your welcome!

@arschles
Copy link
Contributor Author

@harshavardhana just an FYI, three deis v2 components will be using mc, all in docker containers with DOCKERIMAGE=1 set. In my testing it's been working very well.

I will be investigating whether it would be useful to run the minio server with that env variable set as well.

@harshavardhana
Copy link
Member

@harshavardhana just an FYI, three deis v2 components will be using mc, all in docker containers with DOCKERIMAGE=1 set. In my testing it's been working very well.

That is great news, happy to help anytime if you face any issues - you can find us on https://gitter.im/minio/minio

I will be investigating whether it would be useful to run the minio server with that env variable set as well.

You could use our official docker container.

arschles added a commit to arschles/deis-minio that referenced this pull request Dec 17, 2015
This variable ensures that the mc client will work when compiled
without cgo. See minio/mc#1539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants