fix: redact secretKey from printed on screen #4526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
secretKey should not appear in logs.
Motivation and Context
Users may copy/paste logs inadvertently sharing privileges access information.
How to test this PR?
secretKey should not appear when running mc commands with debug e.g.
mc alias set ALIAS URL ACCESSKEY SECRETKEY --debug
Example:
versus
Example:
versus
Types of changes
Checklist:
commit-id
orPR #
here)