Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info: Correctly show pool config with offline node(s) #4567

Merged
merged 1 commit into from
May 9, 2023

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented May 9, 2023

Description

There is a silly bug when the number of disks per set is showing
incorrectly when the last node of a pool is offline.

Fix the code by using the new drives per set/sets count information
sent directly by the server.

Motivation and Context

Fix wrong report of disks per set in mc admin info

How to test this PR?

  • Run a cluster of 4 nodes and kill the last server
  • Run mc admin info and check for disks per set field

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

There is a silly bug when the number of disks per set is showing
incorrectly when the last node of a pool is offline.

Fix the code by using the new drives per set/sets count information
sent directly by the server.
@harshavardhana harshavardhana merged commit 6050568 into minio:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants