bug: panic on nil pointer dereference for "mc admin heal" when disk i… #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s "unformatted"
When a disk unformatted, it seems the .HealInfo struct is not set, but
.Healing is true. This state causes a panic when the program try to
dereference .HealInfo pointer.
the patch check this case, and avois display of "Estimated" time.
the backtrace:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x58 pc=0xebb61f]
goroutine 1 [running]:
github.com/minio/mc/cmd.verboseBackgroundHealStatusMessage.String({{0x1292f87, 0x7}, {{0x0, 0x0, 0x0}, 0x12, {0x0, 0x0, 0x0}, {0xc0004e6000, ...}, ...}, ...})
/home/thierry/git/mc/cmd/admin-heal.go:385 +0x12df
github.com/minio/mc/cmd.printMsg({0x14925b0?, 0xc0000ccc80?})
/home/thierry/git/mc/cmd/print.go:38 +0x11c
github.com/minio/mc/cmd.mainAdminHeal(0xc000103ba0)
/home/thierry/git/mc/cmd/admin-heal.go:641 +0x6c6
github.com/minio/cli.HandleAction({0x10cf280?, 0x1342598?}, 0x4?)
/home/thierry/go/pkg/mod/github.com/minio/cli@v1.24.2/app.go:490 +0x5a
github.com/minio/cli.Command.Run({{0x128d6f4, 0x4}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x12d092e, 0x2c}, {0x0, ...}, ...}, ...)
/home/thierry/go/pkg/mod/github.com/minio/cli@v1.24.2/command.go:242 +0x997
github.com/minio/cli.(*App).RunAsSubcommand(0xc0004bb880, 0xc000103860)
/home/thierry/go/pkg/mod/github.com/minio/cli@v1.24.2/app.go:380 +0xd27
github.com/minio/cli.Command.startApp({{0x128e817, 0x5}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x12a517a, 0x14}, {0x0, ...}, ...}, ...)
/home/thierry/go/pkg/mod/github.com/minio/cli@v1.24.2/command.go:346 +0xb7f
github.com/minio/cli.Command.Run({{0x128e817, 0x5}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0x12a517a, 0x14}, {0x0, ...}, ...}, ...)
/home/thierry/go/pkg/mod/github.com/minio/cli@v1.24.2/command.go:117 +0x418
github.com/minio/cli.(*App).Run(0xc0004ba700, {0xc0000400a0, 0x5, 0x5})
/home/thierry/go/pkg/mod/github.com/minio/cli@v1.24.2/app.go:260 +0xb07
github.com/minio/mc/cmd.Main({0xc0000400a0?, 0x5, 0x5})
/home/thierry/git/mc/cmd/main.go:141 +0x3ec
main.main()
/home/thierry/git/mc/main.go:28 +0x32
harshavardhana
approved these changes
May 15, 2023
|
Please resolve the |
|
gofmt fixed |
klauspost
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a disk is "unformatted", it seems the .HealInfo struct is not set, but .Healing is true. This state causes a panic when the program try to dereference .HealInfo pointer.
the patch check this case, and avoid display of "Estimated" time.
note: maybe
the backtrace:
Motivation and Context
bug fix
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)